Bug: Date-based emails not sending (if set for afternoon)

[bk007]

There's a bug in the latest release of OpenEMM v2013 that can prevent date-based emails from sending.

STEPS TO REPRODUCE
- Load the "Send Mailing" tab of a date-based mailing
- Choose "Daily Delivery Time" between "now + 4 hours" and "23:00h" (the bottom value in the dropdown)

The email will never send if the delivery "hour" is 4 hours (or more) in the future.

MY UNDERSTANDING THUS FAR
There's some funky date code in MailingSendAction (around line 723) that can create a date-based entry in maildrop_status_tbl with a genstatus of 0. The cron sender (RulerImpl) specifically selects mailings with genstatus=1. I'm currently not sure if the fix is to change the 0->1, or if there's some other component that's supposed to set that flag.

Let me know if this is helpful, or if any other info is needed!

[maschoff]

We will investigate this issue, stay tuned!

[bk007]

Awesome.. thank you for looking into it

[maschoff]

I uploaded a new class file MailingSendAction.class to SourceForge:

https://sourceforge.net/projects/openem ... /Bugfixes/

Please stop OpenEMM, replace the file in directory /home/openemm/webapps/openemm/WEB-INF/classes/org/agnitas/web and start OpenEMM again. Does this fix work for you?

[bk007]

Maschoff -

I've confirmed this change fixes the bug.

Thank you much!

[maschoff]

Great, thanks for your confirmation!

[blackgul]

The email will never send if the delivery "hour" is 4 hours (or more) in the future.

MY UNDERSTANDING THUS FAR
There's some funky date code in MailingSendAction (around line 723) that can create a date-based entry in maildrop_status_tbl with a genstatus of 0. The cron sender (RulerImpl) specifically selects mailings with genstatus=1. I'm currently not sure if the fix is to change the 0->1, or if there's some other component that's supposed to set that flag.