Page 1 of 1

a simple tag cannot have additional parameters

Posted: Thu Sep 06, 2007 9:22 pm
by skarphace
Just started using OpenEMM so I could be pulling something stupid. Hopefully you can tell me that. Creating my first mailing for a test, I get this error which I can't pinpoint exactly.
console_stderr.log wrote:triggerMailing: java.lang.Exception: Error while trying to query block 1 :org.agnitas.backend.EMMTagException: ERROR-Code AGN-2007: a simple tag cannot have additional parameters!
org.agnitas.backend.BlockCollection.parseBlock(BlockCollection.java:442)
org.agnitas.backend.BlockCollection.parseBlocks(BlockCollection.java:524)
org.agnitas.backend.MailgunImpl.doPrepare(MailgunImpl.java:236)
org.agnitas.backend.MailgunImpl.prepareMailgun(MailgunImpl.java:101)
org.agnitas.beans.impl.MailingImpl.triggerMailing(MailingImpl.java:660)
org.agnitas.web.MailingSendAction.sendMailing(MailingSendAction.java:457)
org.agnitas.web.MailingSendAction.execute(MailingSendAction.java:202)
org.apache.struts.chain.commands.servlet.ExecuteAction.execute(ExecuteAction.java:58)
org.apache.struts.chain.commands.AbstractExecuteAction.execute(AbstractExecuteAction.java:67)
org.apache.struts.chain.commands.ActionCommandBase.execute(ActionCommandBase.java:51)
org.apache.commons.chain.impl.ChainBase.execute(ChainBase.java:190)
org.apache.commons.chain.generic.LookupCommand.execute(LookupCommand.java:304)
org.apache.commons.chain.impl.ChainBase.execute(ChainBase.java:190)
org.apache.struts.chain.ComposableRequestProcessor.process(ComposableRequestProcessor.java:283)
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1913)
org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:449)
javax.servlet.http.HttpServlet.service(HttpServlet.java:115)
javax.servlet.http.HttpServlet.service(HttpServlet.java:92)
com.caucho.server.dispatch.ServletFilterChain.doFilter(ServletFilterChain.java:106)
org.springframework.orm.hibernate3.support.OpenSessionInViewFilter.doFilterInternal(OpenSessionInViewFilter.java:174)
I've narrowed it down to a problem in my HTML. Why/how does OpenEMM process the HTML and what is it trying to limit me?

I've looked over the HTML and it appears to be valid for e-mail. As in, HTML 3.. Any help or suggestions would be appreciated.

HTML Code

Posted: Fri Sep 07, 2007 7:26 am
by maschoff
Could you post the HTML code in question here?

Posted: Fri Sep 07, 2007 4:44 pm
by skarphace
Here it is. Thanks for the help.

Code: Select all

<table width="600" border="0" align="center" cellpadding="0" cellspacing="0">
        <tr> 
                <td><img src="http://www.domain.com/pvsemail/img/PVS_Email_Header.gif" width="600" height="103"></td>
        </tr>
        <tr> 
                <td background="http://www.domain.com/pvsemail/img/PVS_Email_Body.gif"><img src="http://www.domain.com/pvsemail/img/fill.gif" width="600" height="20"></td>
        </tr>
        <tr> 
                <td background="http://www.domain.com/pvsemail/img/PVS_Email_Line.gif">
                        <table width="600" border="0" cellspacing="0" cellpadding="0">
                                <tr> 
                                        <td align="left" valign="top">
                                                <table width="135" border="0" cellspacing="0" cellpadding="0">
                                                        <tr> 
                                                                <td>
                                                                        <table width="135" border="0" cellspacing="0" cellpadding="0">
                                                                                <tr> 
                                                                                        <td align="left" valign="top">
                                                                                                <img src="http://www.domain.com/pvsemail/img/fill.gif" width="5" height="15"> 
                                                                                        </td>
                                                                                        <td align="left" valign="top">
                                                                                                <table width="130" border="0" cellspacing="0" cellpadding="0">
                                                                                                        <tr> 
                                                                                                                <td height="36"> 
                                                                                                                        <div align="center">
                                                                                                                                <a href="http://www.domain.com/official_five_categories.php"><img src="http://www.domain.com/pvsemail/img/PVS_Email_EOSearch.gif" width="130" height="34" border="0"></a><br>
                                                                                                                                <img src="http://www.domain.com/pvsemail/img/fill.gif" width="130" height="22"><br>
                                                                                                                                <a href="http://www.domain.com/program_donations_index.php"><img src="http://www.domain.com/pvsemail/img/PVS_Email_Donate.gif" width="130" height="41" border="0"></a><br>
                                                                                                                                <img src="http://www.domain.com/pvsemail/img/fill.gif" width="130" height="20"><br>
                                                                                                                                <img src="http://www.domain.com/pvsemail/img/PVS_Email_Sidebar_Line.gif" width="130" height="2"><br>
                                                                                                                                <img src="http://www.domain.com/pvsemail/img/fill.gif" width="130" height="18"><br>
                                                                                                                                <font color="#333333" size="2" face="Arial, Helvetica, sans-serif"><a href="http://www.domain.com/">domain.com</a><br>
                                                                                                                                <br>
                                                                                                                                888-Vote-Smart</font>
                                                                                                                        </div>
                                                                                                                </td>
                                                                                                        </tr>
                                                                                                </table>
                                                                                        </td>
                                                                                </tr>
                                                                        </table>
                                                                </td>
                                                        </tr>
                                                </table>
                                        </td>
                                        <td>
                                                <table width="465" border="0" cellspacing="0" cellpadding="0">
                                                        <tr> 
                                                                <td>
                                                                        <table width="465" border="0" cellspacing="0" cellpadding="0">
                                                                                <tr> 
                                                                                        <td align="left" valign="top"><img src="http://www.domain.com/pvsemail/img/fill.gif" width="27" height="20"></td>
                                                                                        <td>
                                                                                                <table width="408" border="0" cellspacing="0" cellpadding="0">
                                                                                                        <tr> 
                                                                                                                <td>
                                                                                                                        <div align="justify">
                                                                                                                                <font color="#333333" size="2" face="Verdana, Arial, Helvetica, sans-serif"><strong><font color="#000064">[agnDYN name="heading"/]</font></strong><br>
                                                                                                                                <br>
                                                                                                                                [agnTITLE type=1],
                                                                                                                                <br><br>
                                                                                                                                [agnDYN name="maintext"/]
                                                                                                                                <br><br>
                                                                                                                                [agnDYN name="signature"/]
                                                                                                                                <br><br>
                                                                                                                                <font size="1">[agnDYN name="legal"/]</font>

                                                                                                                        </div>
                                                                                                                </td>
                                                                                                        </tr>
                                                                                                </table>
                                                                                        </td>
                                                                                        <td align="left" valign="top"><img src="http://www.domain.com/pvsemail/img/fill.gif" width="30" height="20"></td>
                                                                                </tr>
                                                                        </table>
                                                                </td>
                                                        </tr>
                                                </table>
                                        </td>
                                </tr>
                        </table>
                </td>
        </tr>
        <tr>
                <td background="http://www.domain.com/pvsemail/img/PVS_Email_Body.gif"><img src="http://www.domain.com/pvsemail/img/fill.gif" width="600" height="10"></td>
        </tr>
        <tr> 
                <td><img src="http://www.domain.com/pvsemail/img/PVS_Email_Footer.gif" width="600" height="40"></td>
        </tr>
</table>

closing tag missing

Posted: Fri Sep 07, 2007 9:20 pm
by maschoff
At first look it seems to be ok except for a missing </font> tag - and maybe some more missing tags, did not check everything.

Therefore, could you please first try again with validated HTML code? Maybe this confuses the OpenEMM parser. Thanks!

Posted: Fri Sep 07, 2007 9:44 pm
by skarphace
That appears to be it. I supposed I'll keep a stricter eye next time. Thanks ma.